Skip to content

Commit

Permalink
Update aria-labels for header buttons with notification
Browse files Browse the repository at this point in the history
  • Loading branch information
cchaos committed Sep 14, 2020
1 parent 901a2d0 commit c2fc811
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src-docs/src/views/header/header_dark.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export default ({ theme }: { theme: any }) => (
Production logs
</EuiBadge>,
<EuiHeaderSectionItemButton
aria-label="Notifications"
aria-label="2 Notifications"
notification={'2'}>
<EuiIcon type="cheer" size="m" />
</EuiHeaderSectionItemButton>,
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/header/header_elastic_pattern.js
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,8 @@ export default ({ theme }) => {
items: [
<EuiShowFor sizes={['xs', 's']}>{search}</EuiShowFor>,
<EuiHeaderSectionItemButton
aria-label="Notifications"
notification={true}
aria-label="Notifictations: Updates available"
onClick={() =>
setIsAlertFlyoutVisible(!isAlertFlyoutVisible)
}>
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/header/header_updates.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export default ({ flyoutOrPopover = 'flyout' }) => {
aria-expanded={isFlyoutVisible}
aria-haspopup="true"
aria-label={`News feed: ${
{ showBadge } ? 'Updates available' : 'No updates'
showBadge ? 'Updates available' : 'No updates'
}`}
onClick={() => showFlyout()}
notification={showBadge}>
Expand Down

0 comments on commit c2fc811

Please sign in to comment.