[DOCS] Update SAML URLs #77038
Merged
[DOCS] Update SAML URLs #77038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lockewritesdocs
added
>docs
elasticmachine
added
Team:Security
|
Pinging @elastic/es-security (Team:Security) |
|
Pinging @elastic/es-docs (Team:Docs) |
|
@elasticmachine update branch |
lockewritesdocs
added
the
auto-backport
azasypkin
approved these changes
Sep 1, 2021
|
@elasticmachine update branch |
|
The fips failures are not related to changes in this PR. Leaving links to both build scans to trace back: |
jkakavas
reviewed
Sep 1, 2021
| @@ -77,17 +77,19 @@ POST /_security/saml/prepare | |||
| "realm" : "saml1" | |||
| } | |||
| -------------------------------------------------- | |||
| // TEST[skip:Additional configuration needed in yml files] | |||
There was a problem hiding this comment.
Lets not skip tests without a valid reason. All we need to do here is to change
setting 'xpack.security.authc.realms.saml.saml1.sp.acs', 'https://kibana.org/api/security/v1/saml'
to
setting 'xpack.security.authc.realms.saml.saml1.sp.acs', 'https://kibana.org/api/security/saml/callback'
in x-pack/docs/build.gradle
There was a problem hiding this comment.
@jkakavas, thanks for the pointer! I wasn't sure how to fix the tests that were breaking the build. I'll create a new PR for updating build.gradle.
This was referenced Sep 1, 2021
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Sep 1, 2021
* [DOCS] Update SAML URLs * Fix links and skip tests that require more setup * Fix TESTRESPONSE Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Sep 1, 2021
* [DOCS] Update SAML URLs * Fix links and skip tests that require more setup * Fix TESTRESPONSE Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lockewritesdocs
pushed a commit
that referenced
this pull request
Sep 2, 2021
lockewritesdocs
pushed a commit
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates SAML URLs from
/api/security/v1/samlto/api/security/saml/callback. This change was introduced to the documentationmasterbranch in #47999, but was never backported to7.xbranches.Preview link: https://elasticsearch_77038.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/7.x/saml-guide-stack.html
Relates to #81733 in the Kibana repo
cc: @kcm