-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a snapshot test module to delay shard aggregations #62082
Conversation
This change adds an aggregation that can be used to delay the query phase execution on shards with a configurable time: { "aggs": { "delay": { "shard_delay": { "value": "30s" }, "aggs": { "host": { "terms": { "field": "hostname" } } } } } } This test module is built on top of elastic#61954 so the aggregation will be available only within snapshots since this module is not meant to be used in production. Closes elastic#54159
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Pinging @elastic/es-search (:Search/Search) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the simplicity of the approach. The reliance on wall clock means that you can't do much more automated testing besides making sure that everything keeps working with slow response times, but this still feels useful to me, and even more useful for manual testing.
This change adds an aggregation that can be used to delay the query phase execution on shards with a configurable time: { "aggs": { "delay": { "shard_delay": { "value": "30s" }, "aggs": { "host": { "terms": { "field": "hostname" } } } } } } This test module is built on top of #61954 so the aggregation will be available only within snapshots since this module is not meant to be used in production. Closes #54159
This change adds an aggregation that can be used to delay the
query phase execution on shards with a configurable time:
This test module is built on top of #61954 so the aggregation will be available only within
snapshots since this module is not meant to be used in production.
Closes #54159