Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Edit ILM GS tutorial #51513

Merged
merged 16 commits into from
Feb 4, 2020
Merged

[DOCS] Edit ILM GS tutorial #51513

merged 16 commits into from
Feb 4, 2020

Conversation

debadair
Copy link
Contributor

No description provided.

@debadair debadair added >docs General docs changes WIP :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 v7.6.0 v7.5.3 labels Jan 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @debadair

I think this will be a great improvement and it'll help make the "join the ilm train" experience smoother.

I've left a few suggestions below.

docs/reference/ilm/getting-started-ilm.asciidoc Outdated Show resolved Hide resolved
Comment on lines 20 to 21
. <<ilm-gs-check-progress, Verify that indexes are moving through the lifecycle phases>> as expected with the
you use the {ilm-init} explain API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"with the explain API"

docs/reference/ilm/getting-started-ilm.asciidoc Outdated Show resolved Hide resolved
docs/reference/ilm/getting-started-ilm.asciidoc Outdated Show resolved Hide resolved
<1> The `min_age` field defaults to `0ms` in the hot phase, so new indices immediately enter the hot phase.
<2> The `rollover` action is triggered when any of the conditions are met.
<3> An index is moved into the delete phase after 90 days.
<4> No additional conditions are specified, so the `delete` action is triggered when the index enters the delete phase.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the delete action doesn't support any conditionals/parameters so I think we shouldn't mention conditionals here but rather "The delete action is triggered ..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

docs/reference/ilm/getting-started-ilm.asciidoc Outdated Show resolved Hide resolved
@debadair
Copy link
Contributor Author

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

merge conflict between base and head

@debadair debadair removed the WIP label Jan 31, 2020
Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this @debadair. This is great! There's one typo in the index name , but other than that LGTM


For example, the following request creates an index called `datastream_000001`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datastream_000001 -> datastream-000001


When you continuously index timestamped documents into {es} using
Filebeat, Logstash, or some other mechanism,
you typically use an index alias so you can periodically roll over to a new index.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link for index alias?


To begin, we will want to bootstrap our first index to write to.
To get things started, you need to bootstrap an initial index and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To get things started, you need to bootstrap an initial index and
To get things started, you need to create an initial index and


* Creates a new index called `datastream-000002`.
This matches the `datastream-*` pattern, so the settings from `datastream_template` are applied to the new index.
* Designates the new index as the write index and makes the bootstrap index read-only.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Designates the new index as the write index and makes the bootstrap index read-only.
* Designates the new index as the write index and makes `datastream-000001` read-only.


[source,console]
--------------------------------------------------
GET datastream-*/_ilm/explain
--------------------------------------------------
// TEST[continued]

The above request will retrieve {ilm-init} execution information for all our
managed indices.
The response below shows that the bootstrap index is waiting in the `hot` phase's `rollover` action.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The response below shows that the bootstrap index is waiting in the `hot` phase's `rollover` action.
The response below shows that the `datastream-000001` index is waiting in the `hot` phase's `rollover` action.

after 90 days.
. <<ilm-gs-create-policy, Create a lifecycle policy>> with the {ilm-init} Put policy API.
. <<ilm-gs-apply-policy, Create an index template>> to apply the policy to each new index.
. <<ilm-gs-bootstrap, Bootstrap an index>> as the initial write index.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. <<ilm-gs-bootstrap, Bootstrap an index>> as the initial write index.
. <<ilm-gs-bootstrap, Create an initial write index>>.

The intention here is that the rollover alias is also defined on the index.
[float]
[[ilm-gs-bootstrap]]
=== Bootstrap the initial time-series index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=== Bootstrap the initial time-series index
=== Create an initial time-series index

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor editorial questions/suggestions. Otherwise LGTM.

debadair and others added 9 commits February 4, 2020 13:07
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
@debadair
Copy link
Contributor Author

debadair commented Feb 4, 2020

Thanks for the review @andreidan & @jrodewig!

I stuck with the bootstrap terminology, at least for now. (Though since the term now is mostly associated with the framework, it is potentially problematic.)

@debadair debadair merged commit 8c5cdff into elastic:master Feb 4, 2020
debadair added a commit to debadair/elasticsearch that referenced this pull request Feb 5, 2020
* [DOCS] Edit ILM GS tutorial

* [DOCS] Incorporated review feedback from @andreidan.

* [DOCS] Removed test link & fixed anchor & title.

* Update docs/reference/ilm/getting-started-ilm.asciidoc

Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
debadair added a commit that referenced this pull request Feb 5, 2020
* [DOCS] Align with ILM API docs (#48705)

* [DOCS] Reconciled with Snapshot/Restore reorg

* [DOCS] Split off ILM overview to a separate topic. (#51287)

* [DOCS} Split off overview to a separate topic.

* [DOCS] Incorporated feedback from @jrodewig.

* [DOCS] Edit ILM GS tutorial (#51513)

* [DOCS] Edit ILM GS tutorial

* [DOCS] Incorporated review feedback from @andreidan.

* [DOCS] Removed test link & fixed anchor & title.

* Update docs/reference/ilm/getting-started-ilm.asciidoc

Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

* Fixed glossary merge error.

Co-authored-by: James Rodewig <james.rodewig@elastic.co>
debadair added a commit to debadair/elasticsearch that referenced this pull request Feb 5, 2020
* [DOCS] Align with ILM API docs (elastic#48705)

* [DOCS] Reconciled with Snapshot/Restore reorg

* [DOCS] Split off ILM overview to a separate topic. (elastic#51287)

* [DOCS} Split off overview to a separate topic.

* [DOCS] Incorporated feedback from @jrodewig.

* [DOCS] Edit ILM GS tutorial (elastic#51513)

* [DOCS] Edit ILM GS tutorial

* [DOCS] Incorporated review feedback from @andreidan.

* [DOCS] Removed test link & fixed anchor & title.

* Update docs/reference/ilm/getting-started-ilm.asciidoc

Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

* Fixed glossary merge error.

Co-authored-by: James Rodewig <james.rodewig@elastic.co>
debadair added a commit that referenced this pull request Feb 5, 2020
* [DOCS] Align with ILM API docs (#48705)

* [DOCS] Reconciled with Snapshot/Restore reorg

* [DOCS] Split off ILM overview to a separate topic. (#51287)

* [DOCS} Split off overview to a separate topic.

* [DOCS] Incorporated feedback from @jrodewig.

* [DOCS] Edit ILM GS tutorial (#51513)

* [DOCS] Edit ILM GS tutorial

* [DOCS] Incorporated review feedback from @andreidan.

* [DOCS] Removed test link & fixed anchor & title.

* Update docs/reference/ilm/getting-started-ilm.asciidoc

Co-Authored-By: James Rodewig <james.rodewig@elastic.co>

* Fixed glossary merge error.

Co-authored-by: James Rodewig <james.rodewig@elastic.co>

Co-authored-by: James Rodewig <james.rodewig@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes v7.5.3 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants