Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify connection to Elasticsearch #1623

Merged
merged 4 commits into from
Jun 30, 2021
Merged

Verify connection to Elasticsearch #1623

merged 4 commits into from
Jun 30, 2021

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Jun 28, 2021

Follows this logic for verifying a connection to Elasticsearch:

Before the first API request:

  1. Make an API request to /, inspect the response:
  2. If call to / fails with 401 or 403 pass the check and show a warning (message will be linked later). This happens if the monitor permission missing for user. The subsequent checks must be ignored.
  3. If there's no version field or if the version field value is <6.0.0 raise an error.
  4. If there is a version field and it's >= 6.0.0 and <7.0.0:
    • If there is no tagline field or if the tagline field value isn't You know, for Search raise an error.
  5. If there is a version field and it's >=7.0.0 and <7.14.0:
    • If there is no tagline field or if the tagline field value isn't You know, for Search raise an error.
    • If there is no build_flavor field or if the build_flavor field value isn't default raise an error.
  6. If there is a version field and it's >=7.14.0:
    • If there is no X-Elastic-Product HTTP header in the response or if the X-Elastic-Product HTTP header value isn't Elasticsearch raise an error.

@lnielsen
Copy link

lnielsen commented Jul 14, 2021

It's disappointing to see this :-( You're forcing us as bystanders in a battle to choose sides. We develop an Open Source product that could likely easily work with both Elasticsearch or OpenSearch and then the users can choose for themselves if they want Elasticsearch or OpenSearch. Now, instead, we likely have to make choice for all our users if we want OpenSearch or Elasticsearch. This and other behaviours from Elastic really does not give me any confidence in Elastic and what you might do in the future. And don't blame it all on Amazon - you've already changed the server license, you didn't have to make this move 😞

@philkra
Copy link
Contributor

philkra commented Jul 15, 2021

Amazon OpenSearch is a different product. And while there is some shared history, there are already many differences that cause real confusion and issues.

@elastic elastic locked as resolved and limited conversation to collaborators Aug 7, 2021
@elastic elastic deleted a comment from ruurd Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants