Upgrade to Json.NET 7.0.1 #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/elastic/elasticsearch-net/blob/fix/update-jsonnet/build/NEST.nuspec#L17 We should upgrade our nuspec dependency as well and introduce https://docs.nuget.org/create/versioning The fact that major version range is not implied is a nuget fail IMO though. |
Agreed, just added this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates NEST to Json.NET 7.0.1 and addresses the issue described in #1462.
The problem lied in ElasticContractResolver.CreateProperties. The returned collection of properties was non-unique, causing the DefaultContractResolver in Json.NET to blow up here.
There were some recent changes to
DefaultContractResolver, but I'm not exactly sure what change specifically caused this behavior and if it's a bug or not- but regardless,ElasticContractResolver.CreatePropertiesshould still return a distinct list of properties to be safe.