Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgade node to 14 #997

Merged
merged 3 commits into from
Jan 29, 2021
Merged

build: upgade node to 14 #997

merged 3 commits into from
Jan 29, 2021

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Jan 29, 2021 •
edited
Loading

Summary

Upgrading node to latest LTS one (also used by Kibana)

I've removed the engines requirement from the package.json because that engine is only required for the developer environment and not when using the library as a dependency on another app.

Please update your local version of node with

nvm install 14.15.4
// to make it the default one
nvm alias default 14

@markov00 markov00 added the :build Build tools / dependencies label Jan 29, 2021
rshen91
rshen91 approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@markov00 markov00 mentioned this pull request Jan 29, 2021
Open
11 tasks
@nickofthyme
Copy link
Collaborator

Looks like you need to update the .ci/global_setup.sh file

@markov00
Copy link
Member Author

jenkins test this

@markov00 markov00 merged commit f7d65e5 into elastic:master Jan 29, 2021
@markov00
Copy link
Member Author

🎉 This PR is included in version 24.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jan 30, 2021
@markov00 markov00 deleted the 2021_01_29-upgrade_node branch April 11, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

@rshen91 rshen91 rshen91 approved these changes

@monfera monfera Awaiting requested review from monfera

Assignees
No one assigned
Labels
:build Build tools / dependencies released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markov00 @nickofthyme @rshen91