feat(legend): render multiple columns on float config #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
reviewed
May 20, 2021
| @@ -9,12 +9,6 @@ | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can we change the .echLegendList styles to include grid by default now?
.echLegendList {
display: grid;
}
&--horizontal {
.echLegendList {
grid-column-gap: $echLegendColumnGap;
grid-row-gap: $echLegendRowGap;
margin-top: $echLegendRowGap;
margin-bottom: $echLegendRowGap;
}
}
src/components/legend/style_utils.ts
Outdated
| @@ -68,18 +69,22 @@ export function getLegendListStyle( | |||
| return { | |||
| paddingTop, | |||
| paddingBottom, | |||
| ...(floating && { | |||
| display: 'grid', | |||
There was a problem hiding this comment.
Make default, see previous comment
Suggested change
| display: 'grid', |
src/components/legend/style_utils.ts
Outdated
| @@ -68,18 +69,22 @@ export function getLegendListStyle( | |||
| return { | |||
| paddingTop, | |||
| paddingBottom, | |||
| ...(floating && { | |||
| display: 'grid', | |||
| gridTemplateColumns: `repeat(${clamp(floatingColumns ?? 1, 1, totalItems)}, 1fr`, | |||
There was a problem hiding this comment.
1fr will cause the largest string to control the width for all columns like this....
If we use auto instead of 1fr then each column width will be independent. Not sure which you think is desirable but I like the independent widths.
Suggested change
| gridTemplateColumns: `repeat(${clamp(floatingColumns ?? 1, 1, totalItems)}, 1fr`, | |
| gridTemplateColumns: `repeat(${clamp(floatingColumns ?? 1, 1, totalItems)}, auto`, |
nickofthyme
approved these changes
May 25, 2021
src/components/legend/style_utils.ts
Outdated
| @@ -62,16 +62,15 @@ export function getLegendListStyle( | |||
| return { | |||
| paddingLeft, | |||
| paddingRight, | |||
| gridTemplateColumns: `repeat(auto-fill, minmax(${legendStyle.verticalWidth}px, 1fr))`, | |||
| gridTemplateColumns: `repeat(auto-fill, minmax(${legendStyle.verticalWidth}px, auto))`, | |||
There was a problem hiding this comment.
I don't think this should be auto. The auto with the auto-fill acts differently than without, like below on line 73. I don't see any noticeable difference here so I think we should revert this and revisit how the horizontal legend sizes the columns is a future PR.
Suggested change
| gridTemplateColumns: `repeat(auto-fill, minmax(${legendStyle.verticalWidth}px, auto))`, | |
| gridTemplateColumns: `repeat(auto-fill, minmax(${legendStyle.verticalWidth}px, 1fr))`, |
There was a problem hiding this comment.
done here thanks 8facfeb
nickofthyme
pushed a commit
that referenced
this pull request
May 25, 2021
# [29.2.0](v29.1.0...v29.2.0) (2021-05-25) ### Bug Fixes * **legend:** disable handleLabelClick for one legend item ([#1134](#1134)) ([a7242af](a7242af)), closes [#1055](#1055) ### Features * **a11y:** add alt text for all chart types ([#1118](#1118)) ([9e42229](9e42229)), closes [#1107](#1107) * **legend:** specify number of columns on floating legend ([#1159](#1159)) ([c2e4652](c2e4652)), closes [#1158](#1158) * simple screenspace constraint solver ([#1141](#1141)) ([eb11480](eb11480))
|
🎉 This PR is included in version 29.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [29.2.0](elastic/elastic-charts@v29.1.0...v29.2.0) (2021-05-25) ### Bug Fixes * **legend:** disable handleLabelClick for one legend item ([opensearch-project#1134](elastic/elastic-charts#1134)) ([e485174](elastic/elastic-charts@e485174)), closes [opensearch-project#1055](elastic/elastic-charts#1055) ### Features * **a11y:** add alt text for all chart types ([opensearch-project#1118](elastic/elastic-charts#1118)) ([e1c7489](elastic/elastic-charts@e1c7489)), closes [opensearch-project#1107](elastic/elastic-charts#1107) * **legend:** specify number of columns on floating legend ([opensearch-project#1159](elastic/elastic-charts#1159)) ([ed3736e](elastic/elastic-charts@ed3736e)), closes [opensearch-project#1158](elastic/elastic-charts#1158) * simple screenspace constraint solver ([opensearch-project#1141](elastic/elastic-charts#1141)) ([af9dd96](elastic/elastic-charts@af9dd96))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When rendering a floating legend inside the chart (
Settings.legendPosition.floating:true), the addedSettings.legendPosition.floatingColumnsproperty allows you to specify the number of columns used to distributed the legend items.Connected issues
This feature was added as part of the Kibana Timelion chart library replacement.
fix #1158
Checklist
Delete any items that are not applicable to this PR.
src/index.ts(and stories only import from../srcexcept for test data & storybook)