test(a11y): fix flaky accessibility integration tests #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
rshen91
changed the title
nickofthyme
reviewed
Apr 23, 2021
nickofthyme
reviewed
Apr 26, 2021
nickofthyme
reviewed
Apr 26, 2021
nickofthyme
approved these changes
Apr 26, 2021
|
🎉 This PR is included in version 29.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving some test changes from #1134 into its own PR. Instead of using the puppetteer's accessibility tree, which is sometimes including certain roles and names in the accessiblity tree implementation, these test changes test the HTML of the charts. I think we might be moving to playwright eventually so I'm just loading the HTML for now.
Checklist
Delete any items that are not applicable to this PR.