Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XY] negative bars are not clickable #1100

Closed
1 task
markov00 opened this issue Mar 31, 2021 · 1 comment · Fixed by #1109
Closed
1 task

[XY] negative bars are not clickable #1100

markov00 opened this issue Mar 31, 2021 · 1 comment · Fixed by #1109
Labels
bug Something isn't working :interactions Interactions related issue kibana cross issue Has a Kibana issue counterpart released Issue released publicly :xy Bar/Line/Area chart related

Comments

@markov00
Copy link
Member

Describe the bug
Negative bars on a bar chart are not clickable

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/agitated-benz-indos?file=/src/App.tsx
  2. Click on the negative bar
  3. The console log is not triggered

Expected behaviour
The chart should trigger on element click independently if it's negative or positive value.

Version (please complete the following information):

  • Elastic Charts: master

Errors in browser console
n/a

Kibana Cross Issues

  • Lens issue
@markov00 markov00 added bug Something isn't working kibana cross issue Has a Kibana issue counterpart :interactions Interactions related issue :xy Bar/Line/Area chart related labels Mar 31, 2021
@markov00 markov00 mentioned this issue Apr 6, 2021
Merged
markov00 added a commit that referenced this issue Apr 7, 2021
@markov00
fix(xy): negative bar highlight and click (#1109)
ec17cb2 
fix #1100
nickofthyme pushed a commit that referenced this issue Apr 13, 2021
@semantic-release-bot
chore(release): 28.1.0 [skip ci]
3b712ab 
# [28.1.0](v28.0.1...v28.1.0) (2021-04-13)

### Bug Fixes

* **legend:** sizing for short labels with scrollbar ([#1115](#1115)) ([6e1f223](6e1f223))
* **xy:** negative bar highlight and click ([#1109](#1109)) ([ec17cb2](ec17cb2)), closes [#1100](#1100)

### Features

* **a11y:** improve chart figure ([#1104](#1104)) ([815cf39](815cf39))
* **partition:** order slices and sectors ([#1112](#1112)) ([74df29b](74df29b))
* **partitions:** small multipies events pass on smAccessorValue ([#1106](#1106)) ([a3234fe](a3234fe))
* **xy:** optionally rounds the domain to nice values ([#1087](#1087)) ([f644cc4](f644cc4))
* **xy:** specify pixel and ratio width for bars ([#1114](#1114)) ([58de413](58de413))
* mosaic ([#1113](#1113)) ([64bdd88](64bdd88))
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 28.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Apr 13, 2021
nickofthyme pushed a commit to nickofthyme/elastic-charts that referenced this issue Apr 20, 2021
@markov00 @nickofthyme
fix(xy): negative bar highlight and click (elastic#1109)
11c58f2 
fix elastic#1100
# Conflicts:
#	integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-interactions-bar-clicks-and-hovers-visually-looks-correct-1-snap.png
#	src/chart_types/xy_chart/rendering/rendering.bars.test.ts
#	src/chart_types/xy_chart/state/chart_state.interactions.test.ts
@nickofthyme nickofthyme mentioned this issue Apr 20, 2021
Merged
2 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 28.1.0 [skip ci]
d94ba32 
# [28.1.0](elastic/elastic-charts@v28.0.1...v28.1.0) (2021-04-13)

### Bug Fixes

* **legend:** sizing for short labels with scrollbar ([opensearch-project#1115](elastic/elastic-charts#1115)) ([ebf2552](elastic/elastic-charts@ebf2552))
* **xy:** negative bar highlight and click ([opensearch-project#1109](elastic/elastic-charts#1109)) ([065673c](elastic/elastic-charts@065673c)), closes [opensearch-project#1100](elastic/elastic-charts#1100)

### Features

* **a11y:** improve chart figure ([opensearch-project#1104](elastic/elastic-charts#1104)) ([373ea72](elastic/elastic-charts@373ea72))
* **partition:** order slices and sectors ([opensearch-project#1112](elastic/elastic-charts#1112)) ([72c0d1b](elastic/elastic-charts@72c0d1b))
* **partitions:** small multipies events pass on smAccessorValue ([opensearch-project#1106](elastic/elastic-charts#1106)) ([0e1f7de](elastic/elastic-charts@0e1f7de))
* **xy:** optionally rounds the domain to nice values ([opensearch-project#1087](elastic/elastic-charts#1087)) ([9c2eefc](elastic/elastic-charts@9c2eefc))
* **xy:** specify pixel and ratio width for bars ([opensearch-project#1114](elastic/elastic-charts#1114)) ([6294d5f](elastic/elastic-charts@6294d5f))
* mosaic ([opensearch-project#1113](elastic/elastic-charts#1113)) ([15c0d78](elastic/elastic-charts@15c0d78))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working :interactions Interactions related issue kibana cross issue Has a Kibana issue counterpart released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(xy): negative highlight and click markov00/elastic-charts
2 participants
@markov00 @nickofthyme