Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove apm-beats-update #34487

Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 6, 2023

https://github.com/elastic/apm-server/blob/main/.ci/jobs/update-beats-mbp.yml\#L5 could be the way to do it

What does this PR do?

Remove pipeline to validate whether lib changes could break the APM Server

Why is it important?

Jenkins is deprecated and the CI for elastic/beats will be managed by the ingest team. https://github.com/elastic/apm-server/blob/main/.ci/jobs/update-beats-mbp.yml#L5 could be the alternative even though changes are validated after merging them

@axw , what are your thoughts? Should we rely on update-beats-mbp.yml only for now? (I know we are migrating to GH actions, that job will eventually be migrated). Or is it better to migrate this job too?

@cmacknz , if this job is needed, then it might be required to be migrated to Buildkite? Or maybe GitHub actions could be used instead for this particular use case?

@v1v v1v added automation Team:Automation Label for the Observability productivity team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.6.0 Automated backport with mergify labels Feb 6, 2023
@v1v v1v requested review from axw and cmacknz February 6, 2023 15:07
@v1v v1v self-assigned this Feb 6, 2023
@v1v v1v requested a review from a team as a code owner February 6, 2023 15:07
@v1v v1v requested review from faec and removed request for a team February 6, 2023 15:07
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 6, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-09T07:25:06.135+0000

  • Duration: 13 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@axw
Copy link
Member

axw commented Feb 7, 2023

In the past apm-server has been broken by libbeat library changes, and it wasn't obvious to the libbeat maintainers because apm-server is in a separate repo. It's been quite a while since we saw breaking API changes, excluding Agent V2-related API changes which were communicated ahead of time. I'm not sure how often this CI step has prevented breakage before it reached us though - that's kind of the point. @cmacknz do you know?

@cmacknz
Copy link
Member

cmacknz commented Feb 8, 2023

I'm not sure how often this CI step has prevented breakage before it reached us though - that's kind of the point. @cmacknz do you know?

I don't remember this catching anything recently, but besides agent V2 we haven't made many major changes so the risk of this happening was low.

We could live without this, but it definitely adds the risk that we miss something this automation would have helped us catch.

I think it is valuable to port this workflow to Buildkite as an example of how to trigger automatic updates like this. There will be other repositories for new Elastic Agent inputs outside of Beats in the future and a reference job for how to automatically track the upstream dependency would be helpful.

@v1v
Copy link
Member Author

v1v commented Feb 13, 2023

I think it is valuable to port this workflow to Buildkite as an example of how to trigger automatic updates like this. There will be other repositories for new Elastic Agent inputs outside of Beats in the future and a reference job for how to automatically track the upstream dependency would be helpful.

Perfect! I'll keep this open until the migration has done in Buildkite. Who is leading the migration to Buildkite so I can help with if needed?

@cmacknz
Copy link
Member

cmacknz commented Feb 13, 2023

Who is leading the migration to Buildkite so I can help with if needed?

@mrodm has been tracking the pieces that we need to migrate.

@joshdover
Copy link
Contributor

Given this has been broken for 9 months, any opposition to just merging this now and re-implementing it later on Buildkite?

@joshdover joshdover added backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify and removed backport-v8.6.0 Automated backport with mergify labels May 9, 2023
@joshdover
Copy link
Contributor

Merging this now. If anyone disagrees, we can revert it.

@joshdover joshdover merged commit 18abb98 into elastic:main May 9, 2023
mergify bot pushed a commit that referenced this pull request May 9, 2023
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
(cherry picked from commit 18abb98)
mergify bot pushed a commit that referenced this pull request May 9, 2023
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
(cherry picked from commit 18abb98)
mergify bot pushed a commit that referenced this pull request May 9, 2023
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
(cherry picked from commit 18abb98)

# Conflicts:
#	.ci/apm-beats-update.groovy
joshdover added a commit that referenced this pull request May 9, 2023
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
joshdover added a commit that referenced this pull request May 9, 2023
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@joshdover joshdover removed the backport-7.17 Automated backport to the 7.17 branch with mergify label May 9, 2023
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
@reakaleek reakaleek mentioned this pull request Jul 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants