-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove apm-beats-update #34487
ci: remove apm-beats-update #34487
Conversation
In the past apm-server has been broken by libbeat library changes, and it wasn't obvious to the libbeat maintainers because apm-server is in a separate repo. It's been quite a while since we saw breaking API changes, excluding Agent V2-related API changes which were communicated ahead of time. I'm not sure how often this CI step has prevented breakage before it reached us though - that's kind of the point. @cmacknz do you know? |
I don't remember this catching anything recently, but besides agent V2 we haven't made many major changes so the risk of this happening was low. We could live without this, but it definitely adds the risk that we miss something this automation would have helped us catch. I think it is valuable to port this workflow to Buildkite as an example of how to trigger automatic updates like this. There will be other repositories for new Elastic Agent inputs outside of Beats in the future and a reference job for how to automatically track the upstream dependency would be helpful. |
Perfect! I'll keep this open until the migration has done in Buildkite. Who is leading the migration to Buildkite so I can help with if needed? |
@mrodm has been tracking the pieces that we need to migrate. |
Given this has been broken for 9 months, any opposition to just merging this now and re-implementing it later on Buildkite? |
Merging this now. If anyone disagrees, we can revert it. |
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com> (cherry picked from commit 18abb98)
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com> (cherry picked from commit 18abb98)
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com> (cherry picked from commit 18abb98) # Conflicts: # .ci/apm-beats-update.groovy
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
https://github.com/elastic/apm-server/blob/main/.ci/jobs/update-beats-mbp.yml\#L5 could be the way to do it
What does this PR do?
Remove pipeline to validate whether lib changes could break the APM Server
Why is it important?
Jenkins is deprecated and the CI for elastic/beats will be managed by the ingest team. https://github.com/elastic/apm-server/blob/main/.ci/jobs/update-beats-mbp.yml#L5 could be the alternative even though changes are validated after merging them
@axw , what are your thoughts? Should we rely on
update-beats-mbp.yml
only for now? (I know we are migrating to GH actions, that job will eventually be migrated). Or is it better to migrate this job too?@cmacknz , if this job is needed, then it might be required to be migrated to Buildkite? Or maybe GitHub actions could be used instead for this particular use case?