Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.12] Do not strip leading 0s from traceIds and spanIds if the span source is jaeger (#4671) #4801

Merged
merged 2 commits into from
Feb 18, 2021
Merged

[7.12] Do not strip leading 0s from traceIds and spanIds if the span source is jaeger (#4671) #4801

merged 2 commits into from
Feb 18, 2021

Conversation

axw
Copy link
Member

@axw axw commented Feb 18, 2021

Backports the following commits to 7.x:

@tobiasstadler @axw
Do not strip leading 0s from traceIds and spanIds if the span source …
726e0ea 
…is jaeger (elastic#4671)

* Do not strip leading 0s from traceIds and spanIds if the span source is Jaeger. Jager is in the process of doing the same.

* Added Jaeger trace/span id formatting change to changelog
# Conflicts:
#	changelogs/head.asciidoc
@axw axw added the backport label Feb 18, 2021
@axw axw enabled auto-merge (squash) February 18, 2021 13:03
@apmmachine
Copy link
Contributor

apmmachine commented Feb 18, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #4801 updated

  • Start Time: 2021-02-18T15:49:03.109+0000

  • Duration: 34 min 28 sec

  • Commit: 7a3d347

Test stats 🧪

Test Results
Failed 0
Passed 4373
Skipped 126
Total 4499

Trends 🧪

Image of Build Times

Image of Tests

Steps errors 4

Expand to view the steps failures

Run Window tests
  • Took 10 min 58 sec . View more details on here
Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage
Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests
Test Sync
  • Took 4 min 31 sec . View more details on here
  • Description: ./.ci/scripts/sync.sh

@axw axw changed the base branch from 7.x to 7.12 February 18, 2021 15:45
@axw axw changed the title [7.x] Do not strip leading 0s from traceIds and spanIds if the span source is jaeger (#4671) [7.12] Do not strip leading 0s from traceIds and spanIds if the span source is jaeger (#4671) Feb 18, 2021
@axw axw merged commit 05f5a8a into elastic:7.12 Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axw @apmmachine @tobiasstadler