Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add log_level central config support #1908

Merged
merged 8 commits into from
Dec 8, 2020
Merged

feat: add log_level central config support #1908

merged 8 commits into from
Dec 8, 2020

Conversation

trentm
Copy link
Member

@trentm trentm commented Dec 3, 2020 •
edited
Loading

This changed the supported log levels from:

Possible levels are: `trace`, `debug`, `info`, `warn`, `error`, and `fatal`.

to:

Possible levels are: `trace`, `debug`, `info`, `warning`, `error`, `critical`, and `off`.

For backward compat the old "warn" and "fatal" level names are supported (aliases for "warning" and "critical", respectively).
Notably support for an official "off" for no logging is now supported.

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Dec 3, 2020
@apmmachine
Copy link
Contributor

apmmachine commented Dec 4, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1908 updated

  • Start Time: 2020-12-07T22:01:09.600+0000

  • Duration: 14 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 16398
Skipped 0
Total 16398

@trentm trentm mentioned this pull request Dec 4, 2020
Closed
@trentm
Copy link
Member Author

trentm commented Dec 4, 2020

@elasticmachine, run elasticsearch-ci/docs

@trentm
Copy link
Member Author

trentm commented Dec 4, 2020

jenkins run the module tests for ALL

trentm
trentm commented Dec 4, 2020
View reviewed changes
lib/agent.js Show resolved Hide resolved
trentm
trentm commented Dec 4, 2020
View reviewed changes
lib/agent.js Show resolved Hide resolved
trentm
trentm commented Dec 4, 2020
View reviewed changes
lib/config.js Show resolved Hide resolved
@trentm trentm marked this pull request as ready for review December 4, 2020 02:20
@trentm trentm requested a review from astorm December 4, 2020 02:20
@trentm
Copy link
Member Author

trentm commented Dec 4, 2020

jenkins run the module tests for ALL

astorm
astorm previously approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, as it does the thing and looks good as is. There's an english language nit and an untested testing suggestion I'll leave to your discretion.

docs/configuration.asciidoc Show resolved Hide resolved
lib/agent.js Show resolved Hide resolved
lib/agent.js Show resolved Hide resolved
lib/agent.js Show resolved Hide resolved
lib/tracecontext/tracestate.js Show resolved Hide resolved
lib/tracecontext/tracestate.js Show resolved Hide resolved
test/central-config-enabled.js Outdated Show resolved Hide resolved
@trentm trentm requested a review from astorm December 7, 2020 22:03
@trentm trentm linked an issue Dec 8, 2020 that may be closed by this pull request
[META 321] Add log_level spec #1826
Closed
@trentm trentm merged commit c6c5065 into master Dec 8, 2020
@trentm trentm deleted the trentm/log_level branch December 8, 2020 01:08
@trentm trentm mentioned this pull request Mar 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorm astorm astorm approved these changes

Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[META 321] Add log_level spec
3 participants
@trentm @apmmachine @astorm