Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): response context propagation on Node.js 12.0 - 12.2 #1339

Merged
merged 1 commit into from
Sep 11, 2019
Merged

fix(http): response context propagation on Node.js 12.0 - 12.2 #1339

merged 1 commit into from
Sep 11, 2019

Conversation

Qard
Copy link
Contributor

@Qard Qard commented Sep 11, 2019

As discovered in #1298, context propagation breaks in the http response handler on Node.js 12.0 to 12.2. This ensures that continuation is restored.

Checklist

  • Implement code

@Qard Qard requested a review from watson September 11, 2019 00:04
@Qard Qard self-assigned this Sep 11, 2019
watson
watson approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea with the extra comment 👍

@watson watson merged commit 499871a into elastic:master Sep 11, 2019
@Qard Qard deleted the fix-outgoing-http-response-context-propagation branch September 11, 2019 18:57
@trentm trentm mentioned this pull request Sep 30, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watson watson watson approved these changes

Assignees

@Qard Qard

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qard @watson