Implement partial transactions for AWS Lambda #3134
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
| if (!wasActivated.get()) { | ||
| if (!wasActivated.getAndSet(true)) { | ||
| onFirstActivation(); | ||
| } | ||
| } |
There was a problem hiding this comment.
[minor] the outer if seems redundant here
There was a problem hiding this comment.
This is a small performance optimization: get() on an atomic is a volatile read, which costs the same as a normal read. getAndSet() is an atomic operation (similar to CAS) and therefore comes with the memory-barrier penalty like other atomic operations. I'll add a comment to clarify
| Transaction tx1 = tracer | ||
| .startRootTransaction(null) | ||
| .withName("faas-transaction"); | ||
| tx1.getFaas().withExecution("foo-bar-id"); |
There was a problem hiding this comment.
[question] if I understand correctly the withExecution call makes the transaction as a FAAS transaction, in opposition to a "regular" transaction where this is not called.
| public void setPartialTransactionHandler(Consumer<Transaction> transactionHandler) { | ||
| this.partialTransactionHandler = transactionHandler; | ||
| } |
There was a problem hiding this comment.
It is actually used by the PartialTransactionTest to plugin a real PartialTransactionReporter into the MockReporter.
# Conflicts: # CHANGELOG.asciidoc
What does this PR do?
Closes #2999 .
Checklist
Added an API method or config option? Document in which version this will be introducedI have made corresponding changes to the documentation