add trace level logs for span compressed spans

elastic · Jul 10, 2023 · 3da2d3b · 3da2d3b
1 parent 71bbdf7
commit 3da2d3b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/AbstractSpan.java b/apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/AbstractSpan.java
@@ -571,6 +571,7 @@ public final void end(long epochMicros) {
                 try {
                     if (bufferedSpan.compareAndSet(buffered, null)) {
                         this.tracer.endSpan(buffered);
+                        logger.trace("span compression buffer was set to null and {} was ended", buffered);
                     }
                 } finally {
                     buffered.decrementReferences();

diff --git a/apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/Span.java b/apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/Span.java
@@ -280,6 +280,7 @@ protected void afterEnd() {
                         if (parentBuffered != null) {
                             if (parent.bufferedSpan.compareAndSet(parentBuffered, null)) {
                                 this.tracer.endSpan(parentBuffered);
+                                logger.trace("parent span compression buffer was set to null and {} was ended", parentBuffered);
                             }
                         }
                         this.tracer.endSpan(this);
@@ -292,6 +293,8 @@ protected void afterEnd() {
                             // but we're dropping the compression attempt to keep things simple and avoid looping so this stays wait-free
                             // this doesn't exactly diverge from the spec, but it can lead to non-optimal compression under high load
                             this.tracer.endSpan(this);
+                        } else {
+                            logger.trace("parent span compression buffer was set to {}", this);
                         }
                         return;
                     }
@@ -300,6 +303,7 @@ protected void afterEnd() {
                         // we couldn't compress so replace the buffer with this
                         if (parent.bufferedSpan.compareAndSet(parentBuffered, this)) {
                             this.tracer.endSpan(parentBuffered);
+                            logger.trace("parent span compression buffer was set to {} and {} was ended", this, parentBuffered);
                         } else {
                             // the failed update would ideally lead to a compression attempt with the new buffer,
                             // but we're dropping the compression attempt to keep things simple and avoid looping so this stays wait-free