Final pre-release nits #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubeira
approved these changes
Apr 25, 2017
tangobot_app/app/build.gradle
Outdated
| compile 'org.ros.rosjava_messages:std_msgs:[0.3,)' | ||
| compile 'org.ros.rosjava_messages:sensor_msgs:[0.3,)' | ||
| compile 'org.ros.rosjava_messages:geometry_msgs:[0.3,)' | ||
| compile 'org.ros.rosjava_core:rosjava_helpers:[0.3, 0.4)' |
There was a problem hiding this comment.
Perhaps we could set the correct version for the messages, as they are quite different from the numbers of rosjava releases.
tangobot_app/app/build.gradle
Outdated
| minSdkVersion 15 | ||
| targetSdkVersion 22 | ||
| versionName project.catkin.pkg.version | ||
| versionCode 1 |
There was a problem hiding this comment.
I would add a small comment to remind us that the version code has to be updated manually along with the package's minor version number.
|
Good ideas, @jubeira , thank you. Addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few final changes prior to the initial release:
@jubeira could you please review? Also let me know if you have any other observations prior to release