Liquity Subgraph v1 #8
Conversation
…ption, and clean up comments
…ry mode in liquity subgraph
There was a problem hiding this comment.
most the change requests are small. overall the PR is good! it's quite straight forward.
The one thing I am worried about is that you said some of the entities are not showing up, or null, or something like that. we would have to fix that before merging this PR.
we should move off of this for now, just read the comments and don't worry about fixing them for now. I just wanted to see how the PR looked. Overall it's good. The one problem is those missing and/or null entities
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "network": "ethereum", | |||
There was a problem hiding this comment.
this is an aave file, looks like you copied it over by accident
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "network": "polygon", | |||
| "LendingPoolAddressesProviderRegistryAddress": "0x3ac4e9aa29940770aeC38fe853a4bbabb2dA9C19", | |||
There was a problem hiding this comment.
this is an aave file, looks like you copied it over by accident
| } | ||
|
|
||
| // AssemblyScript can't tell we will never reach this, so it insists on a return statement | ||
| return 'unreached' |
There was a problem hiding this comment.
its easier to just make one of the three options the default of the switch caes
| export let ICR_min = BigDecimal.fromString('1.1') | ||
| export let TCR_min = BigDecimal.fromString('1.5') | ||
| export let EthToLUSD = BigDecimal.fromString('0.9') |
There was a problem hiding this comment.
this kind of stuff should be read from the smart contracts. because if governance votes to change these, the contract breaks.
however i know they have low governance, so maybe these can never be changed. still, i would try to read it from the contract
| export const LUSDAddr = '0x5f98805A4E8be255a32880FDeC7F6728C6568bA0' | ||
|
|
||
| export const LiquityBorrowerOpsAddr = '0x24179CD81c9e782A4096035f7eC97fB8B783e007' |
There was a problem hiding this comment.
these can likely also be read from the contracts
| .concat('-') | ||
| .concat(event.transactionLogIndex.toString()) | ||
| .concat('-') | ||
| .concat('1') |
| .concat('-') | ||
| .concat(event.transactionLogIndex.toString()) | ||
| .concat('-') | ||
| .concat('2') |
| .div(exponentToBigDecimal(asset.decimals)) | ||
| .truncate(asset.decimals) | ||
|
|
||
| if (operation == 'openTrove') { |
There was a problem hiding this comment.
you should do a if else chain with this, and the other two operations. its cleaner.
pseudo code:
if (open trove)
else if (closed trove)
else (adjusted trove)
| let protocol = getProtocol(market.protocol) | ||
| let asset = getOrCreateLUSD(market.collateralBackedAsset) | ||
| let account = getOrCreateAccount(event.params._borrower.toHexString()) | ||
| let operation = getTroveOperationFromBorrowerOperation(event.params._operation) |
There was a problem hiding this comment.
this variable is never used... maybe it can be deleted?
| eventEntry.xTokenAmount = liquidatedCollateralAmount // TODO: not sure if I should have this in here or not in accordance to schema | ||
| eventEntry.amount = LiquidateAmount |
There was a problem hiding this comment.
this looks weird to me, i think there is probably a better way to do it
The intent of this PR is to create and deploy the first iteration of the liquity subgraph that follows the "Lending Subgraph Standard" schema and general intent. The subgraph has been deployed to the hosted service and can be found here.
This PR is just the first draft and further testing, design iterations, and reformatting need to be carried out. There are some issues being seen as well in a couple of entities when querying the subgraph, but the work done so far needed to be reviewed now.
As well, please note that I was having issues with using helper functions and, for the sake of time, wrote the mappings within mainly two large event handlers. This would, of course, be reformatted in future iterations. The data also needs to be confirmed by comparing to other reputable data sources still.
Notes and TODOs are outlined within the README, and there are related TODO's commented within the respective mapping files.
NOTE: rebasing and commit squashing may be needed before merging to main since there are "WIP commits" and I had accidentally run
yarn prettier-writeon the entire repo which edited the some of the AAVE and possibly other protocol-related subgraph files