Test all warnings variants

ehmicky · Apr 1, 2019 · 1effa04 · 1effa04
1 parent f697cbb
commit 1effa04
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 4 deletions.
diff --git a/src/error/message.js b/src/error/message.js
@@ -45,9 +45,7 @@ const multipleResolves = function({
 }) {
   const rejectedStr = REJECTED_NAME[rejected]
   const nextRejectedStr = REJECTED_NAME[nextRejected]
-  // istanbul ignore next
   const again = rejected === nextRejected ? ' again' : ''
-  // istanbul ignore next
   const state = again ? rejectedStr : 'resolved/rejected'
 
   return `a promise was ${state} multiple times:

diff --git a/test/helpers/emit/warning.js b/test/helpers/emit/warning.js
@@ -6,12 +6,27 @@ const { promisify } = require('util')
 const pSetImmediate = promisify(setImmediate)
 
 // Emit a `warning` event
-const warning = async function() {
-  emitWarning('message', { type: 'WarningType', code: '500', detail: 'Detail' })
+const warning = async function({ all = false } = {}) {
+  const props = all ? WARNING_PROPS : [WARNING_PROPS[0]]
+  props.forEach(createWarning)
 
   await pSetImmediate()
 }
 
+const createWarning = function({ code, detail }, index) {
+  // Ensure events are not skipped because they look like repeated events.
+  const type = index === 0 ? 'WarningType' : `WarningType${index}`
+
+  emitWarning('message', { type, code, detail })
+}
+
+const WARNING_PROPS = [
+  { code: '500', detail: 'Detail' },
+  { code: '500' },
+  { detail: 'Detail' },
+  {},
+]
+
 module.exports = {
   warning,
 }
diff --git a/test/snapshots/log.js.md b/test/snapshots/log.js.md
@@ -111,4 +111,28 @@ Generated by [AVA](https://ava.li).
       `Warning: WarningType: message␊
       [500] Detail`,
       'warn',
+      `‼  warning (WarningType1)  message␊
+      [500] ␊
+          at STACK TRACE`,
+      `Warning: WarningType1: message␊
+      [500] ␊
+          at STACK TRACE`,
+      `Warning: WarningType1: message␊
+      [500] `,
+      'warn',
+      `‼  warning (WarningType2)  message␊
+      Detail␊
+          at STACK TRACE`,
+      `Warning: WarningType2: message␊
+      Detail␊
+          at STACK TRACE`,
+      `Warning: WarningType2: message␊
+      Detail`,
+      'warn',
+      `‼  warning (WarningType3)  message␊
+          at STACK TRACE`,
+      `Warning: WarningType3: message␊
+          at STACK TRACE`,
+      'Warning: WarningType3: message',
+      'warn',
     ]
diff --git a/test/snapshots/log.js.snap b/test/snapshots/log.js.snap