Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dts): terminate worker when work is done #1142

Merged
merged 3 commits into from
Jul 20, 2024
Merged

fix(dts): terminate worker when work is done #1142

merged 3 commits into from
Jul 20, 2024

Conversation

SunsetTechuila
Copy link
Contributor

@SunsetTechuila SunsetTechuila commented Jun 10, 2024 •
edited
Loading

related oven-sh/bun#11760

nothing changes for node, but now tsup can be run on bun: bun --bun tsup

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jun 10, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@vercel Vercel
Copy link

vercel bot commented Jun 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 11:11pm

@SunsetTechuila
Copy link
Contributor Author

SunsetTechuila commented Jun 11, 2024 •
edited
Loading

differs from #1140 in that the worker does not control its own lifecycle + covers the error when typescript is not installed

@SunsetTechuila
Copy link
Contributor Author

@egoist hello, would appreciate a review from you

@sxzz sxzz force-pushed the dev branch 2 times, most recently from 115a451 to 57654f6 Compare July 16, 2024 21:02
@SunsetTechuila
Copy link
Contributor Author

@sxzz or maybe you can take a look, please?

@sxzz
Copy link
Collaborator

sxzz commented Jul 20, 2024

I'm not very familiar with this part of the code, so I can't review it.

Since Bun already has a issue, we can wait for them to fix compatibility.

@SunsetTechuila
Copy link
Contributor Author

SunsetTechuila commented Jul 20, 2024 •
edited
Loading

I'm not very familiar with this part of the code, so I can't review it.

Behavior doesn't change, added code just manually doing what happens automatically on node

Since Bun already has a issue, we can wait for them to fix compatibility.

This could take forever

@sxzz sxzz merged commit 44c88a7 into egoist:dev Jul 20, 2024
8 checks passed
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 8.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sxzz sxzz mentioned this pull request Jul 20, 2024
Closed
@SunsetTechuila
Copy link
Contributor Author

Ty

@FilipPyrek FilipPyrek mentioned this pull request Jul 28, 2024
Closed
@dev-badace dev-badace mentioned this pull request Aug 1, 2024
Closed
@erossignon erossignon mentioned this pull request Aug 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SunsetTechuila @sxzz