Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#52 Add support for override the #121

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeffrichards
Copy link

Having a go at issue #52

Adds a command line parameter --override_currency="YOUR_CURRENCY" which is then set as the currency for the print out. It also supports --override_currency="" which is my use case, where all my entries to date simply don't have a currency and that's the way I like them.

I think this is roughly following the conventions for how you've got for new code. I tried to write up a test, but the truth is I haven't been able to successfully run the test suite on my local machine, so I'm not sure if it'll pass although I think it looks about right...

@egh
Copy link
Owner

egh commented Apr 6, 2021

This looks good, although the tests don't seem to pass. (I've been meaning to convert to pytest but haven't found the time. So apologies for the less-nice testing framework).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants