Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use globby@11 #236

Merged
merged 2 commits into from
Jan 1, 2023
Merged

feat: use globby@11 #236

merged 2 commits into from
Jan 1, 2023

Conversation

superiums
Copy link
Contributor

@superiums superiums commented Dec 19, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

update globby . affected fast-glob update.
the old globby depends on fast-glob 2.x
this will leads lots of egg module to request a such a directory must exist:

    egg-schedule/app/schedule
    egg-session/app/schedule
    egg-security/app/schedule
    ....
    egg-schedule/app/service
    egg-session/app/service
    egg-security/app/service
    ....
    egg-schedule/io/middleware
    egg-session/io/middleware
    egg-security/io/middleware
    ....

if the directory not exists, it throws an exception.
so we sould update the fast-glob.

Description of change

update globby

not use globby 12.x because it support ES module only.

@fengmk2
Copy link
Member

fengmk2 commented Jan 7, 2022

egg-core still need to support node 8, but globby@11 only support node >= 10 https://github.com/sindresorhus/globby/blob/v11.0.4/package.json#L14

We will merge this pull request on egg@3.
cc @hyj1991

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Base: 99.76% // Head: 99.76% // No change to project coverage 👍

Coverage data is based on head (687a6cb) compared to base (540f3fe).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          19       19           
  Lines        2935     2935           
  Branches      546      546           
=======================================
  Hits         2928     2928           
  Misses          7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2 fengmk2 added the egg3 label Jan 7, 2022
@fengmk2
Copy link
Member

fengmk2 commented Dec 19, 2022

I will merge soon, we will release a major version egg-core and drop Node.js < 14 support

@fengmk2 fengmk2 changed the title Update globby. feat: use globby@11 Jan 1, 2023
@fengmk2 fengmk2 merged commit c8898ac into eggjs:master Jan 1, 2023
atian25 pushed a commit that referenced this pull request Jan 1, 2023
[skip ci]

## [5.1.0](v5.0.0...v5.1.0) (2023-01-01)

### Features

* use globby@11 ([#236](#236)) ([c8898ac](c8898ac))
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants