Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patronum v2.0 #300

Merged
merged 32 commits into from
Nov 28, 2023
Merged

Patronum v2.0 #300

merged 32 commits into from
Nov 28, 2023

Conversation

AlexandrHoroshih
Copy link
Member

@AlexandrHoroshih AlexandrHoroshih commented Oct 11, 2023 •
edited
Loading

Fixes #175

@AlexandrHoroshih AlexandrHoroshih changed the title Use effector 23 release candidate Patronum v2.0 Oct 11, 2023
AlexandrHoroshih and others added 28 commits October 12, 2023 22:25
@AlexandrHoroshih
Remove forward calls
2a94b6b
@AlexandrHoroshih
Remove guard usage
0008daf
@AlexandrHoroshih
greedy: true -> batch: false
4dd3e19
@AlexandrHoroshih
remove fork(domain) usage
821deb6
@AlexandrHoroshih
Remove onlyChanges usage
4b61108
@AlexandrHoroshih
Use skipVoid: false
01bbf43
@AlexandrHoroshih
use the same TS version, which is used for effector
33e35c4
@AlexandrHoroshih
Comply with TS deprecations and cut unrelevant lib check
d0a5233
@AlexandrHoroshih
Make empty operator work with full-void stores
265bd07
@AlexandrHoroshih
Use UnitTargetable
001203a
@zerobias
Add skipVoid to maps and combines (#302)
f9e4927 
* Add skipVoid

* Use skipVoid false
@AlexandrHoroshih
Use latest rc
006bf38
@AlexandrHoroshih
Update tests to reflect fixed bug
50aa8a7
@AlexandrHoroshih
Remove test for derived event call - it is not supported anymore
69214f3
@AlexandrHoroshih
Update and tests
dc95249
@AlexandrHoroshih
Update or tests
e1cd7f0
@AlexandrHoroshih
Remove controversial type tests
560e3f6 
Strict check was expected for a valid case with partial match
@AlexandrHoroshih
Remove type tests for domain or scope in source
8c7a1f9
@AlexandrHoroshih
Update combine-events type tests
106acac
@AlexandrHoroshih
Fix build
9bf2719
@AlexandrHoroshih
Test types against dist
e07af37
@AlexandrHoroshih
Fix condition types
b4bac9d
@AlexandrHoroshih
Fix {} in every and some tests
53072cf
@AlexandrHoroshih
Fix name support in debounce
76026df
@AlexandrHoroshih
Fix spread types
19482f7
@yumauri @victordidenko
Fix double debounce trigger (#303)
9a9081a 
Co-authored-by: Victor Didenko <victord@setplex.com>
@AlexandrHoroshih
Skip failing cases
61ec454
@zerobias
Add effector 23 support (#304)
8fd97ae 
* Update effector version

* Set range of supported effector versions

* Ensure that `and` and `or` will updated with scope
@zerobias zerobias added the BREAKING CHANGES Some features changes without backward compatibility label Nov 27, 2023
@zerobias zerobias marked this pull request as ready for review November 28, 2023 08:13
@zerobias
Fix ci issues (#307)
9ab85fe 
* Update cra integration

* Fix lockfile for node 16/18 ci

* Use non-strict peer deps in cra integration

* Update pnpm

* Update lockfile

* Update cra lockfile

* Update custom integration

* Reorder imports
zerobias
zerobias approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@zerobias zerobias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☄️ ☄️ ☄️

@zerobias zerobias merged commit 9731c2d into main Nov 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerobias zerobias zerobias approved these changes

Assignees
No one assigned
Labels
BREAKING CHANGES Some features changes without backward compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patronum v2.0 Danainae
4 participants
@AlexandrHoroshih @zerobias @yumauri @kireevmp