fix scrolling to top of form when switching from undefined value to s…

…ome value
eea · Feb 3, 2023 · 877d385 · 877d385
1 parent baa5b83
commit 877d385
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/src/Widgets/ThemePicker.jsx b/src/Widgets/ThemePicker.jsx
@@ -3,11 +3,20 @@ import { Form } from 'semantic-ui-react';
 import { Grid, Button } from 'semantic-ui-react';
 
 const ThemePicker = (props) => {
-  const { id, title, required, value, onChange, colors, className } = props;
+  const {
+    id,
+    title,
+    required,
+    defaultValue = 'no-theme',
+    value,
+    onChange,
+    colors,
+    className,
+  } = props;
 
   React.useEffect(() => {
-    if (!props.value && props.default) {
-      props.onChange(props.id, props.default);
+    if (!value && defaultValue) {
+      onChange(id, defaultValue);
     }
   });
 

diff --git a/src/index.js b/src/index.js
@@ -4,7 +4,7 @@ const applyConfig = (config) => {
   config.widgets.widget.theme_picker = ThemePickerWidget;
 
   config.settings.themeColors = [
-    { value: undefined, title: 'No theme' },
+    { value: 'no-theme', title: 'No theme' },
     { value: 'primary', title: 'Primary' },
     { value: 'secondary', title: 'Secondary' },
     { value: 'tertiary', title: 'Tertiary' },