feat: Added support for node v16 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraarif
approved these changes
Feb 14, 2022
aht007
force-pushed
the
jenkins/node-16-6f268ac
branch
from
229de91
to
6f268ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 30 30
Branches 6 6
=========================================
Hits 30 30 Continue to review full report at Codecov.
|
Jawayria
reviewed
Mar 8, 2022
| "eslint-plugin-import": "^2.25.4", | ||
| "eslint-plugin-jsx-a11y": "^6.5.1", | ||
| "eslint-plugin-react": "^7.29.2", | ||
| "eslint-plugin-react-hooks": "^4.3.0", |
There was a problem hiding this comment.
Why do we need to add all these eslint dependencies instead of just upgrading eslint version?
There was a problem hiding this comment.
These packages were installed due to @edx/eslint-config. eslint-config-edx is deprecated and doesn't support node16 so we have to replace that with newer package @edx/eslint-config
Jawayria
approved these changes
Mar 9, 2022
iamsobanjaved
approved these changes
Mar 17, 2022
aht007
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional information from script execution
Python code cleanup by the cleanup-python-code Jenkins job.
This pull request was generated by the cleanup-python-code Jenkins job, which ran
The following packages were installed:
edx-repo-toolsDeleted obsolete pull_requests:
#29