feat: Add Core Keeper registry client #138
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
===========================================
- Coverage 83.62% 67.33% -16.29%
===========================================
Files 3 5 +2
Lines 287 597 +310
===========================================
+ Hits 240 402 +162
- Misses 25 146 +121
- Partials 22 49 +27 ☔ View full report in Codecov by Sentry. |
internal/pkg/keeper/client.go
Outdated
| } | ||
|
|
||
| func (k *keeperClient) RegisterCheck(id string, name string, notes string, url string, interval string) error { | ||
| // keeper combines service discovery and health check into one single register request |
There was a problem hiding this comment.
This needs to be implemented. The are users that have added additional RegisterChecks via this API
There was a problem hiding this comment.
Keeper does not support this for now, may be an enhancement in the future.
There was a problem hiding this comment.
That is a breaking change then as this is current functionality when using Consul. @cloudxxx8 FYI.
There was a problem hiding this comment.
@lenny-intel it's not really breaking anything
core-keeper requires the healthcheck setting when the registration creation
https://github.com/edgexfoundry/go-mod-core-contracts/blob/7c7fc6d4916a7b9a2c91d36c929726a20a3654c9/dtos/registration.go#L20
Consul requires a separated call to this RegisterCheck, but there is no impact if core-keeper does nothing in RegisterCheck func
closes edgexfoundry#134 Signed-off-by: Jack Chen <jack@iotechsys.com>
closes #134
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)