Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add AuthMethod on intervalaction API when security enabled #816

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

cherrycl
Copy link
Contributor

@cherrycl cherrycl commented Apr 7, 2023

Closes #809

Also fixed:

  1. Update the service name for the change on edgex-compose PR #361
  2. Delete events on suite teardown to avoid the error on next suite

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Cherry Wang <cherry@iotechsys.com>
@cherrycl cherrycl requested a review from cloudxxx8 April 7, 2023 06:17
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit a2658a4 into edgexfoundry:main Apr 7, 2023
@cherrycl cherrycl deleted the issue-809 branch July 21, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update intervalAction request body to add AuthMode when security enabled
2 participants