Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security services bootstrap handlers incorrectly returns false in success case #4106

Closed
lenny-goodell opened this issue Jul 28, 2022 · 0 comments · Fixed by #4107
Closed

Security services bootstrap handlers incorrectly returns false in success case #4106

lenny-goodell opened this issue Jul 28, 2022 · 0 comments · Fixed by #4107
Assignees
@lenny-goodell
Labels
bug Something isn't working
Milestone
Levski

Comments

@lenny-goodell
Copy link
Member

🐞 Bug Report

Affected Services [REQUIRED]

The issue is located in:

Is this a regression?

No

Description and Minimal Reproduction [REQUIRED]

File Token Provider's bootstrap handler incorrectly returns false in success case which with latest go-mod-bootstrap case the exe for exit with non-zero exit code.

🔥 Exception or Error

Exits with non-zero exit code

🌍 Your Environment

Deployment Environment:

EdgeX Version [REQUIRED]:

Anything else relevant?
@lenny-goodell lenny-goodell added the bug Something isn't working label Jul 28, 2022
@lenny-goodell lenny-goodell added this to the Levski milestone Jul 28, 2022
@lenny-goodell lenny-goodell self-assigned this Jul 28, 2022
lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Jul 28, 2022
fix: File Token Provider handler return true/false properly
2b937e7 
Also updated to latest go mods which exposed this issue.

fixe edgexfoundry#4106

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell mentioned this issue Jul 28, 2022
Merged
5 tasks
@lenny-goodell lenny-goodell linked a pull request Jul 28, 2022 that will close this issue
fix: Security services' bootstrap handler return true/false properly #4107
Merged
5 tasks
@lenny-goodell lenny-goodell changed the title File Token Provider's bootstrap handler incorrectly returns false in success case Security services bootstrap handlers incorrectly returns false in success case Jul 28, 2022
jim-wang-intel pushed a commit that referenced this issue Jul 29, 2022
fix: Security services' bootstrap handler return true/false properly (#…
4804402 
…4107)

* fix: File Token Provider handler return true/false properly

Also updated to latest go mods which exposed this issue.

fixe #4106

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* fix: Proper retun value from bootstrap handlers

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* fix: config and spiffy token provider

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* fix: Switch one shot services to use RunAndReturnWaitGroup

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* fix: Removed unneed explist ignore of return parameters

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenny-goodell lenny-goodell

Labels
bug Something isn't working
Projects
None yet
Milestone
Levski
Development

Successfully merging a pull request may close this issue.

fix: Security services' bootstrap handler return true/false properly lenny-goodell/edgex-go
1 participant
@lenny-goodell