Proposed windows fixes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey guys, ran into and fixed some issues on my Windows machine. Replaced line 29 with ruby equivalent because `touch` isn't on most windows machines Replaced single quotes with double quotes on line 31 since also breaking on windows Thanks :)
Missed the trailing bracket, good now...
| @@ -26,9 +26,9 @@ file GH_PAGES_REF => BUILD_DIR do | |||
| sh "git checkout gh-pages" | |||
| else | |||
| sh "git checkout --orphan gh-pages" | |||
| sh "touch index.html" | |||
| FileUtils.touch(File.join(BUILD_DIR, 'index.html')) | |||
There was a problem hiding this comment.
Is the absolute path necessary here considering the current directory is already the BUILD_DIR?
|
Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, ran into and fixed some issues on my Windows machine.
Replaced line 29 with ruby equivalent because
touchisn't available on most windows machinesReplaced single quotes with double quotes on line 31 since also breaking on windows
Thanks :)