chore(the-product): change tab url when select variation #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leomp12
reviewed
Jul 4, 2023
| const searchParams = new URLSearchParams(window.location.search) | ||
| searchParams.set('variation_id', variationId) | ||
| const newRelativePathQuery = `${window.location.pathname}?${searchParams.toString()}` | ||
| history.pushState(null, '', newRelativePathQuery); |
There was a problem hiding this comment.
Era pra variar com o URL eu acredito
There was a problem hiding this comment.
Co-authored-by: Leonardo Matos <leomp120894@gmail.com>
leomp12
approved these changes
Jul 6, 2023
|
O único problema é que o "voltar" do navegador ficou uma bosta na página de produto 🙃 |
|
Na verdade acho que isso foi uma má ideia kkk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Google set an example: https://www.usereserva.com/camiseta-pica-pau-bordado-neon0079375/p?idsku=412225&
When changing variations, the URL should be updated in the tab. They mentioned having a robot that emulates a human, so when accessing a link from the merchant, they select each variation and compare if that variation has a unique URL.