Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve on multiconditionals/switch/select case #384

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

MichaelSt98
Copy link
Collaborator

Improve on multiconditionals/switch/select case for c-like-backends ...
this includes handling of RangeIndex as case value

Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/384/index.html

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.48%. Comparing base (cc179b3) to head (a63ba1d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   95.48%   95.48%   -0.01%     
==========================================
  Files         185      185              
  Lines       38646    38658      +12     
==========================================
+ Hits        36902    36913      +11     
- Misses       1744     1745       +1     
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 95.47% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat addition! I left a question otherwise GTG!

loki/backend/cgen.py Show resolved Hide resolved
Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. LGTM

@reuterbal reuterbal force-pushed the nams-cgen-improve-multiconditional branch from d92f9d6 to a63ba1d Compare October 7, 2024 07:11
@reuterbal reuterbal added the ready for merge This PR has been approved and is ready to be merged label Oct 7, 2024
Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat indeed. Looks great, GTG. :shipit:

@reuterbal reuterbal merged commit 3a0919d into main Oct 7, 2024
13 checks passed
@reuterbal reuterbal deleted the nams-cgen-improve-multiconditional branch October 7, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants