-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed logical evaluation of PRESENT intrinsics on Array variables #341
Merged
mlange05
merged 9 commits into
ecmwf-ifs:main
from
JoeffreyLegaux:bugfix-inlining-present-array
Aug 13, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5b4fc70
Fixed logical evaluation of PRESENT intrinsics on Array variables
JoeffreyLegaux fd410b6
Added test for evaluation on PRESENT intrinsic when inlining routine …
JoeffreyLegaux bf30dfa
Split statement across multiple line to avoid excessive line length
JoeffreyLegaux c4711cb
removed trailing whitespace
JoeffreyLegaux a62719f
removed useless variable declaration from test
JoeffreyLegaux 524f8fc
removed useless variables declarations from test
JoeffreyLegaux 94850ca
added missing argument and imports
JoeffreyLegaux 952a779
exclude OMNI frontend from test
JoeffreyLegaux 65b58a1
Merge branch 'main' into bugfix-inlining-present-array
mlange05 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMNI currently fails this test, highlighting that the source is not valid fortran at the moment:
In particular,
klev
,kidia
,kfdia
,ktdia
, andydmf_phys_out
are missing from the subroutine interface, and we should include dummy imports oftxfu
andmf_phys_out_type
. That makes this at least fully correct Fortran code.OMNI will then still fail the test because it is going to lack the relevant type definitions, so it is fine to exclude it from the frontend parameterisation as xfail.