Loki: Add a 1% code coverage degradation threshold #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/112/index.html |
|
Looks good. I would suggest merging into #109 to fix checks there, so main is green afterwards |
reuterbal
approved these changes
Jul 2, 2023
|
1% overall degradation is maybe too generous for larger PRs but it should only be a review aid rather than an absolute metric anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filing this as a separate PR to get input on the level of degradation we should allow. I've gone for 1% per PR, which would easily work for most of the maintenance PRs, where this is the biggest issue. Opinions and comments welcome.