-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 64 bits uniformly for length child of arraycmp opcode #6992
Comments
Also note that how the |
Spencer-Comin
changed the title
32 bits is too small for arraycmp length child
Use 64 bits uniformly for length child of arraycmp opcode
Feb 8, 2024
Spencer-Comin
added a commit
to Spencer-Comin/omr
that referenced
this issue
Apr 16, 2024
Previously the arraycmp IL opcode's length child was specified as 32 bits but was inconsistent in its use. This commit changes the specification of the length child to 64 bits, and normalizes the use to 64 bits. Closes: eclipse#6992 Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
added a commit
to Spencer-Comin/omr
that referenced
this issue
Apr 17, 2024
Previously the arraycmp IL opcode's length child was specified as 32 bits but was inconsistent in its use. This commit changes the specification of the length child to 64 bits, and normalizes the use to 64 bits. Closes: eclipse#6992 Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
added a commit
to Spencer-Comin/omr
that referenced
this issue
Apr 17, 2024
Previously the arraycmp IL opcode's length child was specified as 32 bits but was inconsistent in its use. This commit changes the specification of the length child to 64 bits, and normalizes the use to 64 bits. Closes: eclipse#6992 Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
@0xdaryl is this something that would warrant discussion at an architecture meeting? |
Spencer-Comin
added a commit
to Spencer-Comin/omr
that referenced
this issue
Apr 25, 2024
Previously the arraycmp IL opcode's length child was specified as 32 bits but was inconsistent in its use. This commit changes the specification of the length child to 64 bits, and normalizes the use to 64 bits. Closes: eclipse#6992 Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
added a commit
to Spencer-Comin/omr
that referenced
this issue
May 1, 2024
Previously the arraycmp IL opcode's length child was specified as 32 bits but was inconsistent in its use. This commit changes the specification of the length child to 64 bits, and normalizes the use to 64 bits. Closes: eclipse#6992 Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
added a commit
to Spencer-Comin/omr
that referenced
this issue
May 1, 2024
Previously the arraycmp IL opcode's length child was specified as 32 bits but was inconsistent in its use. This commit changes the specification of the length child to 64 bits, and normalizes the use to 64 bits. Closes: eclipse#6992 Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
added a commit
to Spencer-Comin/omr
that referenced
this issue
May 1, 2024
Previously the arraycmp IL opcode's length child was specified as 32 bits but was inconsistent in its use. This commit changes the specification of the length child to 64 bits, and normalizes the use to 64 bits. Closes: eclipse#6992 Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Reopening as pull request #7313 needed to be reverted temporarily due to downstream breakage. |
Fixed by #7388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During discussions related to #6951 it was mentioned that having the length input to
arraycmp
as a signed 32-bit integer is unnecessarily restrictive given that arrays can cover more than 231-1 bytes, and current platform implementations may not work as expected for lengths that exceed 231-1.The text was updated successfully, but these errors were encountered: