Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing TCK tests for Emitters + mpMetrics integration #162

Open
abutch3r opened this issue Oct 16, 2023 · 0 comments
Open

Missing TCK tests for Emitters + mpMetrics integration #162

abutch3r opened this issue Oct 16, 2023 · 0 comments

Comments

@abutch3r
Copy link
Contributor

abutch3r commented Oct 16, 2023

The specification for Reactive Messaging's integration with mpMetrics is defined here https://download.eclipse.org/microprofile/microprofile-reactive-messaging-3.0/microprofile-reactive-messaging-spec-3.0.html#_metrics.

The Spec only mentions channels, in no way does it specify directionality, or especially in the case of outgoing channels how the messages are put effectively 'sent', whether it is via an emitter or an @Outgoing.

While reviewing the TCK, there are tests for the @Outgoing and @Incoming annotations to check the counts for each channel relating to them. However there are no tests for checking counts on channels which have an emitter associated with them. This can lead to a gap were an implementation might not count messages sent via an emitter onto a channel.

The test must emit messages to a connector, such that @Incoming does not itself update the channel count. the connector can put out to an @Incoming so that a comparison between messages having been put on the the outgoing channel meet those that reach the end of the stream

abutch3r added a commit to abutch3r/microprofile-reactive-messaging that referenced this issue Feb 22, 2024
Fail overflow test can fail to pass if exception is thrown after more then 256 messages have been processed

eclipse#162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant