Skip to content

Commit

Permalink
Oracle: Lightweight Connection Validation
Browse files Browse the repository at this point in the history
See #1450

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
  • Loading branch information
tsegismont committed Jul 26, 2024
1 parent 3417c5a commit f0c1ffc
Showing 1 changed file with 10 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
import io.vertx.core.*;
import io.vertx.core.internal.ContextInternal;
import io.vertx.core.internal.PromiseInternal;
import io.vertx.core.internal.logging.Logger;
import io.vertx.core.internal.logging.LoggerFactory;
import io.vertx.core.net.SocketAddress;
import io.vertx.core.spi.metrics.ClientMetrics;
import io.vertx.core.tracing.TracingPolicy;
Expand All @@ -33,6 +35,8 @@

public class OracleJdbcConnection implements Connection {

private static final Logger log = LoggerFactory.getLogger(OracleJdbcConnection.class);

private final ClientMetrics metrics;
private final OracleConnection connection;
private final OracleMetadata metadata;
Expand Down Expand Up @@ -103,7 +107,12 @@ public boolean isSsl() {

@Override
public boolean isValid() {
return true;
try {
return connection.isValid(OracleConnection.ConnectionValidation.SOCKET, 0);
} catch (SQLException e) {
log.trace("Failed to validate connection", e);
return false;
}
}

@Override
Expand Down

0 comments on commit f0c1ffc

Please sign in to comment.