-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/10453 fix proxy config #9
Conversation
…proxy script while building it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emsameen If you might have a task, would it be possible for you to create a k3d Cluster and test it that apps are deployed and run successfully?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rom3be fix linter
Coverage after merging bugfix/10453-fix-proxy-config into main will be
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Next improvement shall consider:
- finding a better fix for the redundant proxy setup in every script files
- observe and regression issue due to the removal of the wgetrc proxy setup.
Thanks!
@@ -96,13 +96,6 @@ if [ "${USE_PROXIES}" = "true" ]; then | |||
git config --global https.proxy ${HTTPS_PROXY} | |||
fi | |||
|
|||
echo "# Proxy settings" >> /etc/wgetrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to observe any regression issue with the wget due to this change.
- But currently no action is required
Description
Azure DevOps PBI/Task reference
AB#[PBI/Task number]
Checklist
Vehicle App can be started with dapr run and is connecting to vehicle data broker
Vehicle App can process MQTT messages and call the seat service
Vehicle App can be deployed to local K3D and is running
Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.
Extended the documentation in Velocitas repo
Extended the documentation in README.md
[ x ] Devcontainer can be opened successfully
[ x ] Devcontainer can be opened successfully behind a corporate proxy
[ x ] Devcontainer can be re-built successfully
Release workflow is passing