Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Codeql disable #87

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Fix: Codeql disable #87

merged 2 commits into from
Jan 10, 2023

Conversation

mml5bg
Copy link
Contributor

@mml5bg mml5bg commented Jan 10, 2023

Description

CodeQL has been disabled.

Azure DevOps PBI/Task reference

AB#11669

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

@github-actions
Copy link

github-actions bot commented Jan 10, 2023

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 1b2b391. ± Comparison against base commit b246ff4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 10, 2023

Trivy Scan Results (sampleapp)

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 1b2b391. ± Comparison against base commit b246ff4.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doosuu
Copy link
Member

doosuu commented Jan 10, 2023

LGTM

@mml5bg mml5bg merged commit 0caf8ee into main Jan 10, 2023
@mml5bg mml5bg deleted the bugfix/disable-codeql branch January 10, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants