Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporarily fix for linter and generic integration tests #68

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

dennismeister93
Copy link
Contributor

Signed-off-by: Dennis Meister dennis.meister@bosch.com

Description

For BCX we want to ensure that newly generated projects are not failing due to linting errors or failing integration tests

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ -1s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 52e0586. ± Comparison against base commit e838794.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Trivy Scan Results (sampleapp)

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 52e0586. ± Comparison against base commit e838794.

Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dennismeister93 dennismeister93 merged commit d599446 into main Nov 4, 2022
@dennismeister93 dennismeister93 deleted the fix/bcx-lint-int-test-fix branch November 4, 2022 16:56
@dennismeister93 dennismeister93 restored the fix/bcx-lint-int-test-fix branch November 4, 2022 16:56
@dennismeister93 dennismeister93 deleted the fix/bcx-lint-int-test-fix branch November 4, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants