Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out test asserts for template application #67

Conversation

BjoernAtBosch
Copy link
Member

Description

Comment out the non-generic unit and integration tests to easily allow users to start with own code after cloning the template repo and not bothered with failing tests of example code.

Azure DevOps PBI/Task reference

AB#11187

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

@BjoernAtBosch BjoernAtBosch force-pushed the topic/disable_non-generic_tests branch 3 times, most recently from 7ad6735 to 6a5f23e Compare November 4, 2022 15:07
@BjoernAtBosch BjoernAtBosch changed the title Comment out test code for template application Comment out test asserts for template application Nov 4, 2022
@BjoernAtBosch BjoernAtBosch marked this pull request as ready for review November 4, 2022 15:17
Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine :)

@BjoernAtBosch BjoernAtBosch merged commit e838794 into eclipse-velocitas:main Nov 4, 2022
@BjoernAtBosch BjoernAtBosch deleted the topic/disable_non-generic_tests branch November 4, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants