Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new return type for DataPoints #64

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Conversation

doosuu
Copy link
Member

@doosuu doosuu commented Nov 3, 2022

Description

Adapt the template to the use of the new TypedDataPointResult of the updated SDK

Azure DevOps PBI/Task reference

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Test Results

1 tests  ±0   1 ✔️ ±0   1s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 1ecdbe3. ± Comparison against base commit cdfa368.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Trivy Scan Results (sampleapp)

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 1ecdbe3. ± Comparison against base commit cdfa368.

Copy link
Member

@emsameen emsameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doosuu doosuu merged commit d1469cd into main Nov 4, 2022
@doosuu doosuu deleted the datapoints-timestamps branch November 4, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants