Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove login to ghcr.io #5

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Fix: Remove login to ghcr.io #5

merged 1 commit into from
Jul 6, 2022

Conversation

mml5bg
Copy link
Contributor

@mml5bg mml5bg commented Jul 5, 2022

Description

Remove login to ghcr.io

Azure DevOps PBI/Task reference

AB#10659

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Trivy Scan Results (seatadjuster)

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit ffa3360. ± Comparison against base commit ee5c4ec.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Unit Test Results

4 tests  ±0   4 ✔️ ±0   6s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit ffa3360. ± Comparison against base commit ee5c4ec.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Coverage after merging bugfix-10659 into main will be

93.88%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/SeatAdjusterApp
   test_run.py93.88%100%100%93.88%114–115, 118

@mml5bg mml5bg requested a review from emsameen July 5, 2022 11:32
Copy link
Member

@emsameen emsameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mml5bg mml5bg merged commit 161da86 into main Jul 6, 2022
@mml5bg mml5bg deleted the bugfix-10659 branch December 13, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants