Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make black and flake8 compatible #202

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Conversation

mml5bg
Copy link
Contributor

@mml5bg mml5bg commented Oct 6, 2023

Description

This PR fixes compatibility between black and flake8 settings.

Issue ticket number and link

https://github.com/orgs/eclipse-velocitas/projects/7?pane=issue&itemId=37837378

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

BjoernAtBosch
BjoernAtBosch previously approved these changes Oct 10, 2023
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kse3hi
Copy link
Contributor

kse3hi commented Oct 11, 2023

Please check why some checks are failing.

setup.cfg Outdated Show resolved Hide resolved
Co-authored-by: Serhii Korchynskyi <serhii.korchynskyi@etas.com>
Copy link
Contributor

@kse3hi kse3hi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kse3hi kse3hi merged commit 8400245 into main Oct 11, 2023
8 checks passed
@kse3hi kse3hi deleted the fix-black-and-flake8-compatibility branch October 11, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants