Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update VAL components #2

Merged
merged 2 commits into from
Jul 4, 2022
Merged

fix: update VAL components #2

merged 2 commits into from
Jul 4, 2022

Conversation

emsameen
Copy link
Member

@emsameen emsameen commented Jun 30, 2022

Description

  • update prerequisites versions
  • update service scripts with the new changes on the VAL components
  • add new feeder config files for the seat adjuster use case
  • update the k3d setup to overwrite the CAN dump, DBC file and the mapping file

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

- update prerequisites versions
- update service scripts with the new changes on the VAL components
- add new feeder config files for the seat adjuster use case
@github-actions
Copy link

github-actions bot commented Jun 30, 2022

Trivy Scan Results (seatadjuster)

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 6ad8a00. ± Comparison against base commit e52db26.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 30, 2022

Unit Test Results

4 tests  ±0   4 ✔️ ±0   6s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 6ad8a00. ± Comparison against base commit e52db26.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

Coverage after merging updae_val_components into main will be

93.88%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/SeatAdjusterApp
   test_run.py93.88%100%100%93.88%114–115, 118

@emsameen emsameen requested a review from MP91 July 4, 2022 09:02
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested behind the proxy

@emsameen emsameen merged commit 5750d28 into main Jul 4, 2022
@emsameen emsameen deleted the updae_val_components branch July 4, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants