Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt for new appManifest v3 #185

Merged
merged 10 commits into from
Aug 28, 2023
Merged

adopt for new appManifest v3 #185

merged 10 commits into from
Aug 28, 2023

Conversation

MP91
Copy link
Contributor

@MP91 MP91 commented Aug 21, 2023

Description

Adopt the template for the new appManifest v3

Issue ticket number and link

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but digital.auto needs to implement the new project-generator version first

@MP91
Copy link
Contributor Author

MP91 commented Aug 22, 2023

LGTM but digital.auto needs to implement the new project-generator version first

do we also need to adapt something?

shall we wait with merging than?

Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MP91 MP91 merged commit 3d6c162 into main Aug 28, 2023
7 checks passed
@MP91 MP91 deleted the appManifest_v3 branch August 28, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants