Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Import of seat-adjuster example from SDK #160

Merged
merged 7 commits into from
Jun 13, 2023

Conversation

BjoernAtBosch
Copy link
Member

@BjoernAtBosch BjoernAtBosch commented Jun 7, 2023

Description

Fix the import of the seat-adjuster example from the SDK

Issue ticket number and link

Quick fix for #159

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

File Coverage Lines Branches
All files 100% 100% 100%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 1797fa8

app/requirements-links.txt Outdated Show resolved Hide resolved
@BjoernAtBosch BjoernAtBosch marked this pull request as ready for review June 13, 2023 08:09
Copy link
Contributor

@kse3hi kse3hi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants