Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New app manifest #143

Merged
merged 23 commits into from
May 24, 2023
Merged

New app manifest #143

merged 23 commits into from
May 24, 2023

Conversation

BjoernAtBosch
Copy link
Member

Description

Adaptations needed for new AppManifest concept:

Issue ticket number and link

AB#12908, AB#13658

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

@github-actions
Copy link

github-actions bot commented May 9, 2023

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 8441f5a. ± Comparison against base commit 7e57217.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 10, 2023

Trivy Scan Results (SampleApp)

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
1 files    0

Results for commit 8441f5a.

♻️ This comment has been updated with latest results.

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93 dennismeister93 marked this pull request as ready for review May 24, 2023 07:09
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MP91 MP91 merged commit 2bd8995 into main May 24, 2023
@MP91 MP91 deleted the new-app-manifest branch May 24, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants