-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New app manifest #143
Merged
Merged
New app manifest #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
dennismeister93
force-pushed
the
new-app-manifest
branch
from
May 16, 2023 13:23
90a6f79
to
278a350
Compare
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
MP91
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dennismeister93
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adaptations needed for new AppManifest concept:
Issue ticket number and link
AB#12908, AB#13658
Checklist
Vehicle App can be started with dapr run and is connecting to vehicle data broker
Vehicle App can process MQTT messages and call the seat service
Vehicle App can be deployed to local K3D and is running
Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.
Extended the documentation in Velocitas repo
Extended the documentation in README.md
Devcontainer can be opened successfully
Devcontainer can be opened successfully behind a corporate proxy
Devcontainer can be re-built successfully
Release workflow is passing