-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedercan log level change #13
Conversation
Coverage after merging can-feeder-log-level-change into main will be
Coverage Report
|
@@ -46,7 +46,7 @@ spec: | |||
- name: VEHICLEDATABROKER_DAPR_APP_ID | |||
value: {{.Values.imageVehicleDataBroker.daprAppid}} | |||
- name: LOG_LEVEL | |||
value: "info,databroker=info,dbcfeeder.broker_client=debug,dbcfeeder=debug" | |||
value: "info,databroker=info,dbcfeeder.broker_client=info,dbcfeeder=info" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, however did you try that?
When you run feedercan, there should no longer be repeating logs. Please verify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is tested and there were no repeating logs
Description
Change of log level for feedercan from debug to info.
Azure DevOps PBI/Task reference
AB#10826
Checklist
Vehicle App can be started with dapr run and is connecting to vehicle data broker
Vehicle App can process MQTT messages and call the seat service
Vehicle App can be deployed to local K3D and is running
Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.
Extended the documentation in Velocitas repo
Extended the documentation in README.md
Devcontainer can be opened successfully
Devcontainer can be opened successfully behind a corporate proxy
Devcontainer can be re-built successfully
Release workflow is passing