Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Revert mount to devcontainer #106

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix: Revert mount to devcontainer #106

merged 1 commit into from
Feb 2, 2023

Conversation

mml5bg
Copy link
Contributor

@mml5bg mml5bg commented Feb 2, 2023

Description

This PR fixes issue with K3d, mount to devcontainer was missing.

Azure DevOps PBI/Task reference

AB#[PBI/Task number]

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit a113df1. ± Comparison against base commit 1ba14f1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Trivy Scan Results (sampleapp)

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit a113df1. ± Comparison against base commit 1ba14f1.

@mml5bg mml5bg requested a review from emsameen February 2, 2023 18:25
Copy link
Member

@emsameen emsameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emsameen emsameen merged commit f2f0165 into main Feb 2, 2023
@emsameen emsameen deleted the bugfix/k3d-mount-issue branch February 2, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants