Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vspec link in AppManifest #103

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Vspec link in AppManifest #103

merged 3 commits into from
Feb 2, 2023

Conversation

mml5bg
Copy link
Contributor

@mml5bg mml5bg commented Feb 2, 2023

Description

This PR adds link to Vspec to AppManifest.json.

Azure DevOps PBI/Task reference

AB#12509

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Trivy Scan Results (sampleapp)

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit e61bc3a. ± Comparison against base commit 3649eb6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit e61bc3a. ± Comparison against base commit 3649eb6.

♻️ This comment has been updated with latest results.

@mml5bg mml5bg requested a review from doosuu February 2, 2023 06:59
Copy link
Member

@doosuu doosuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt the location and attribute name to what we have discussed yesterday:

"vehiclemodel": {
    "src": "<path_to_vspec>"
}

@mml5bg mml5bg requested a review from doosuu February 2, 2023 07:26
app/AppManifest.json Outdated Show resolved Hide resolved
Copy link
Member

@emsameen emsameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

  • please adapt as recommended from @doosuu.
  • Thanks!

@mml5bg mml5bg requested a review from doosuu February 2, 2023 14:04
@mml5bg mml5bg merged commit 1ba14f1 into main Feb 2, 2023
@mml5bg mml5bg deleted the vss-ref-in-app-manifest branch February 2, 2023 17:45
dennismeister93 pushed a commit that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants